Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v6.x backport] doc, lib, test: do not re-require needlessly #14876

Closed
wants to merge 1 commit into from
Closed

[v6.x backport] doc, lib, test: do not re-require needlessly #14876

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Aug 16, 2017 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc, lib, test

Backport of #14244

@nodejs-github-bot nodejs-github-bot added process Issues and PRs related to the process subsystem. repl Issues and PRs related to the REPL subsystem. v6.x labels Aug 16, 2017
@vsemozhetbyt vsemozhetbyt mentioned this pull request Aug 16, 2017
Closed
4 tasks
@vsemozhetbyt
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/9699/

@vsemozhetbyt vsemozhetbyt added doc Issues and PRs related to the documentations. test Issues and PRs related to the tests. labels Aug 16, 2017
@BridgeAR
Copy link
Member

@nodejs/lts

@MylesBorins MylesBorins force-pushed the v6.x-staging branch 2 times, most recently from aaf4e13 to 31f572c Compare September 5, 2017 16:50
@vsemozhetbyt
Copy link
Contributor Author

Rebased.

@MylesBorins
Copy link
Contributor

MylesBorins commented Sep 19, 2017 •
edited
Loading

landed in 38ae5c4

@vsemozhetbyt vsemozhetbyt deleted the backport-14244-to-v6.x branch September 19, 2017 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. repl Issues and PRs related to the REPL subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vsemozhetbyt @BridgeAR @MylesBorins @nodejs-github-bot