Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test for cluster benchmarks #14812

Closed
wants to merge 1 commit into from
Closed

test: add test for cluster benchmarks #14812

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 13, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test benchmark cluster

@Trott Trott added benchmark Issues and PRs related to the benchmark subsystem. cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests. labels Aug 13, 2017
@Trott
Copy link
Member Author

Trott commented Aug 14, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/9658/

Trott added a commit to Trott/io.js that referenced this pull request Aug 18, 2017
@Trott
test: add test for cluster benchmarks
0c5ea12 
Add minimal test to make sure cluster benchmark code runs.

PR-URL: nodejs#14812
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
@Trott
Copy link
Member Author

Trott commented Aug 18, 2017

Landed in 0c5ea12

@Trott Trott closed this Aug 18, 2017
@targos targos mentioned this pull request Sep 3, 2017
Closed
MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
@Trott @MylesBorins
test: add test for cluster benchmarks
e263c02 
Add minimal test to make sure cluster benchmark code runs.

PR-URL: #14812
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Sep 10, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
@Trott @MylesBorins
test: add test for cluster benchmarks
1217b1a 
Add minimal test to make sure cluster benchmark code runs.

PR-URL: #14812
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
@MylesBorins
Copy link
Contributor

run.js doesn't exist in v6.x

Is there another way to accomplish the same thing? Marking do-not-land for now.

@Trott
Copy link
Member Author

Trott commented Sep 25, 2017

Not landing this on v6.x seems fine to me.

@Trott Trott deleted the test-benchmark-cluster branch January 13, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@danbev danbev danbev approved these changes

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@hiroppy hiroppy hiroppy approved these changes

Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem. cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @MylesBorins @refack @danbev @jasnell @cjihrig @hiroppy