Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8.x backport] encoding: rudimentary TextDecoder support w/o ICU #14786

Closed
wants to merge 1 commit into from
Closed

[v8.x backport] encoding: rudimentary TextDecoder support w/o ICU #14786

wants to merge 1 commit into from

Conversation

TimothyGu
Copy link
Member

Also split up the tests.

PR-URL: #14489
Reviewed-By: James M Snell [email protected]
Reviewed-By: Refael Ackermann [email protected]

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

encoding

@TimothyGu
encoding: rudimentary TextDecoder support w/o ICU
2ab406e 
Also split up the tests.

PR-URL: nodejs#14489
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@TimothyGu TimothyGu added the encoding Issues and PRs related to the TextEncoder and TextDecoder APIs. label Aug 12, 2017
@TimothyGu TimothyGu requested a review from jasnell August 12, 2017 09:25
@nodejs-github-bot nodejs-github-bot added encoding Issues and PRs related to the TextEncoder and TextDecoder APIs. errors Issues and PRs related to JavaScript errors originated in Node.js core. v8.x labels Aug 12, 2017
@TimothyGu TimothyGu mentioned this pull request Aug 12, 2017
Closed
3 tasks
@TimothyGu
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/9625/

addaleax pushed a commit that referenced this pull request Aug 12, 2017
@TimothyGu @addaleax
encoding: rudimentary TextDecoder support w/o ICU
c5ee34e 
Also split up the tests.

Backport-PR-URL: #14786
Backport-Reviewed-By: Anna Henningsen <[email protected]>

PR-URL: #14489
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@addaleax
Copy link
Member

Landed in c5ee34e, thanks for backporting!

@addaleax addaleax closed this Aug 12, 2017
@TimothyGu TimothyGu deleted the v8.x-14489 branch March 26, 2018 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
encoding Issues and PRs related to the TextEncoder and TextDecoder APIs. errors Issues and PRs related to JavaScript errors originated in Node.js core.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TimothyGu @addaleax @nodejs-github-bot