Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: add comments for cares library init refcount #14743

Closed
wants to merge 1 commit into from
Closed

src: add comments for cares library init refcount #14743

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Ref: #14738

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src/cares_wrap

@XadillaX

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. labels Aug 10, 2017
bnoordhuis
bnoordhuis approved these changes Aug 10, 2017
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. With the recent changes, can the refcount ever drop to zero now?

@addaleax
Copy link
Member Author

With the recent changes, can the refcount ever drop to zero now?

Not the way lib/dns.js currently works, no.

XadillaX
XadillaX approved these changes Aug 10, 2017
View reviewed changes
Copy link
Contributor

@XadillaX XadillaX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@XadillaX
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/9613/

addaleax added a commit that referenced this pull request Aug 11, 2017
@addaleax
src: add comments for cares library init refcount
eb8f574 
Ref: #14738
PR-URL: #14743
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@addaleax
Copy link
Member Author

This doesn’t need to wait 48 hours, landed in eb8f574

@addaleax addaleax closed this Aug 11, 2017
@addaleax addaleax deleted the cares-comments branch August 11, 2017 19:35
addaleax added a commit that referenced this pull request Aug 12, 2017
@addaleax
src: add comments for cares library init refcount
d7d22ea 
Ref: #14738
PR-URL: #14743
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@addaleax addaleax mentioned this pull request Aug 13, 2017
Merged
@MylesBorins
Copy link
Contributor

This does not land cleanly in LTS. Please feel free to manually backport by following the guide. Please also feel free to replace do-not-land if it is being backported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@jasnell jasnell jasnell approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@cjihrig cjihrig cjihrig approved these changes

@XadillaX XadillaX XadillaX approved these changes

@tniessen tniessen tniessen approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@addaleax @XadillaX @MylesBorins @bnoordhuis @jasnell @TimothyGu @cjihrig @tniessen @nodejs-github-bot