src,http2: DRY header/trailer handling code up #14688
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove duplicate code through minor refactoring.
addaleax
added
c++
nodejs-github-bot
added
c++
bnoordhuis
approved these changes
Aug 8, 2017
src/node_http2_core.h
Outdated
| virtual void OnFreeSession() {} | ||
| virtual void AllocateSend(size_t suggested_size, uv_buf_t* buf) = 0; | ||
|
|
||
| virtual bool HasGetPaddingCallback() { return false; } | ||
|
|
||
| class SubmitTrailers { | ||
| public: | ||
| void operator ()(nghttp2_nv* trailers, size_t length) const; |
There was a problem hiding this comment.
Making this a normal method called .Send() or whatever is clearer, IMO. No risk of confusing method calls with plain function calls.
cjihrig
approved these changes
Aug 8, 2017
danbev
approved these changes
Aug 8, 2017
3 tasks
|
Landed in d98606f |
addaleax
added a commit
that referenced
this pull request
Aug 10, 2017
Remove duplicate code through minor refactoring. PR-URL: #14688 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
jasnell
pushed a commit
to jasnell/node
that referenced
this pull request
Aug 13, 2017
Remove duplicate code through minor refactoring. PR-URL: nodejs#14688 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
addaleax
added a commit
that referenced
this pull request
Aug 14, 2017
Remove duplicate code through minor refactoring. PR-URL: #14688 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove duplicate code through minor refactoring.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src/http2