Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix test-readline-interface #14681

Closed
wants to merge 2 commits into from
Closed

fix test-readline-interface #14681

wants to merge 2 commits into from

Commits on Aug 8, 2017

  1. lib: use Timer.now() in readline module 

    Using Date.now() introduces problems when operating under load or
otherwise with constrained resources. Use Timer.now() to mitigate.

The problem was identified in `test-readline-interface` where under
heavy load, `\r` and `\n` were received so far apart that they were
treated as separate line endings rather than a single line ending.
Switching to `Timer.now()` prevented this from happening.

Refs: nodejs#14674
    @Trott
    Trott committed Aug 8, 2017
    Configuration menu
    Copy the full SHA
    9f1370f View commit details
    Browse the repository at this point in the history

  2. test: split out load-sensitive readline tests 

    Two test cases in `test-readline-interface` are sensitive to resource
constraints (probably due to `\r` and `\n` not arriving within the
appropriate delay to be treated as a single line ending). Move those
tests to `sequential`.

Fixes: nodejs#14674
    @Trott
    Trott committed Aug 8, 2017
    Configuration menu
    Copy the full SHA
    710304c View commit details
    Browse the repository at this point in the history