-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix test-readline-interface short delay #14677
Conversation
@@ -331,8 +331,8 @@ function isWarned(emitter) { | |||
// over the default crlfDelay but within the setting value | |||
{ | |||
const fi = new FakeInput(); | |||
const delay = 200; | |||
const crlfDelay = 500; | |||
const delay = common.platformTimeout(125); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this be more reliable without common.platformTimeout()
here but keeping it in the line below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Trott Make sense, I have changed this line.
Stress test on master (should show failures): https://ci.nodejs.org/job/node-stress-single-test-pi1-fanned/27/ Stress test on this PR (should be green): https://ci.nodejs.org/job/node-stress-single-test-pi1-fanned/28/ |
CI is good, stress tests are great, change is small, will help flip one of our CI tasks from red to green, 4 approvals, so I'm going to fast-track this... |
Landed in f11379d |
Previous unit test delay is too short for parallel test on raspberry pi, it will fail sometimes. This PR use common.platformTimeout and widen the time gap. PR-URL: nodejs#14677 Ref: nodejs#14674 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Previous unit test delay is too short for parallel test on raspberry pi, it will fail sometimes. This PR use common.platformTimeout and widen the time gap. PR-URL: #14677 Ref: #14674 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Previous unit test delay is too short for parallel test on raspberry pi, it will fail sometimes. This PR use common.platformTimeout and widen the time gap. PR-URL: #14677 Ref: #14674 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Previous unit test delay is too short for parallel test on raspberry pi, it will fail sometimes.
This PR use
common.platformTimeout
and widen the time gap, a patch of #13497Refs: #14674
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
readline