test: explain sloppy mode for test-global #14604
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refack
approved these changes
Aug 3, 2017
cjihrig
approved these changes
Aug 3, 2017
lpinca
approved these changes
Aug 3, 2017
|
While you are here, would you mind to swap the first two arguments of |
benjamingr
approved these changes
Aug 3, 2017
thefourtheye
approved these changes
Aug 3, 2017
jasnell
approved these changes
Aug 3, 2017
Add a comment explaining why test-global runs in sloppy mode rather than strict mode. While in the file, make some minor changes to the module ordering and spacing to conform with our test writing guide. Also reordered arguments in `assert.strictEqual()` to match documentation.
Trott
force-pushed
the
test-global-strict
branch
from
e644157 to
c7a981c
Compare
Done! |
gibfahn
approved these changes
Aug 5, 2017
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Aug 5, 2017
Add a comment explaining why test-global runs in sloppy mode rather than strict mode. While in the file, make some minor changes to the module ordering and spacing to conform with our test writing guide. Also reordered arguments in `assert.strictEqual()` to match documentation. PR-URL: nodejs#14604 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
|
Landed in ff65a2e |
addaleax
pushed a commit
that referenced
this pull request
Aug 7, 2017
Add a comment explaining why test-global runs in sloppy mode rather than strict mode. While in the file, make some minor changes to the module ordering and spacing to conform with our test writing guide. Also reordered arguments in `assert.strictEqual()` to match documentation. PR-URL: #14604 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a comment explaining why test-global runs in sloppy mode rather than
strict mode. While in the file, make some minor changes to the module
ordering and spacing to conform with our test writing guide.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test