Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: avoid dereference without existence check #14591

Closed
wants to merge 1 commit into from
Closed

src: avoid dereference without existence check #14591

wants to merge 1 commit into from

Commits on Aug 5, 2017

  1. src: avoid dereference without existence check 

    Currently the URL API is only used from the JS binding, which always
initializes `base` regardless of `has_base`. Therefore, there is no
actual security risk right now, but would be had we made other C++ parts
of Node.js use this API.

Refs: nodejs#14369 (comment)
    @bmeck @TimothyGu
    bmeck authored and TimothyGu committed Aug 5, 2017
    Configuration menu
    Copy the full SHA
    fc18a69 View commit details
    Browse the repository at this point in the history