doc,net: assign deprecation code #14576
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missed while landing 75a19fb. Ref: nodejs#14449
Fishrock123
approved these changes
Aug 1, 2017
jasnell
approved these changes
Aug 1, 2017
|
Landed in 8a8a686 |
addaleax
added a commit
that referenced
this pull request
Aug 1, 2017
Missed while landing 75a19fb. Ref: #14449 PR-URL: #14576 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed this while landing 75a19fb.
Ref: #14449
I’d suggest to fast-track this as it’s a trivial fix (if CI is green).
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes (presumably, V8 is taking forever to compile and it’s not like there’s much I could have done wrong here 😄)Affected core subsystem(s)
net