build: fix shared library flags logic #1454
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, land at will. |
|
LGTM, feel free to land. |
Fishrock123
added a commit
to Fishrock123/node
that referenced
this pull request
Apr 17, 2015
Fixes a regession introduced in fd90b33 PR-URL: nodejs#1454 Reviewed-By: Chris Dickinson <[email protected]>
Fishrock123
force-pushed
the
fix-shared-lib-configure
branch
from
236c072
to
1b22bad
Compare
|
@jbergstroem thanks, didn't get you in on the Reviewed-By though. Landed in 1b22bad |
This was referenced May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An even smaller fix than #1450
See: #1436 (comment)