doc: fix some links #14400
Closed
doc: fix some links #14400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
approved these changes
Jul 20, 2017
lpinca
approved these changes
Jul 20, 2017
mscdex
added
dns
hiroppy
approved these changes
Jul 21, 2017
XadillaX
approved these changes
Jul 21, 2017
|
I've fixed another one in |
tniessen
reviewed
Jul 21, 2017
doc/guides/writing-tests.md
Outdated
| (https://github.com/nodejs/lts). [node.green](http://node.green/) lists | ||
| available features in each release. | ||
| features that can be used directly without a flag in | ||
| [all maintained branches](https://github.com/nodejs/lts). |
There was a problem hiding this comment.
Maybe move these links to the bottom as we usually do?
There was a problem hiding this comment.
There are 5 links in the doc without references. Should I move them all to the bottom?
There was a problem hiding this comment.
I am not entirely sure, but considering that there are three links in the footer, I would prefer consistency. In most cases that makes sense, but barely for [here](https://github.com/nodejs/testing/issues/27). I am fine if you leave it as it is, just wanted to suggest that, didn't know there were so many other "inline" links. So feel free to change it or leave it, I really don't know what we should go for.
There was a problem hiding this comment.
Done for all except [here] ad hoc link.
jasnell
approved these changes
Jul 21, 2017
|
Landed in 4d1e086 |
vsemozhetbyt
added a commit
that referenced
this pull request
Jul 23, 2017
PR-URL: #14400 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Jul 24, 2017
PR-URL: #14400 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: James M Snell <[email protected]>
Closed
Merged
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Apr 10, 2018
PR-URL: nodejs#14400 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 16, 2018
Backport-PR-URL: #19447 PR-URL: #14400 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
I am not sure about
[][]type links in the DNS doc. Do they mean two-dimensional array, as stated in thedns.resolveTxt()description? If so, let me know to revert (and they should be fixed in doc tools as now they are not rendered as links).