doc: fix inspectPort documentation in cluster.md #14349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
added
cluster
nodejs-github-bot
added
cluster
cjihrig
approved these changes
Jul 18, 2017
This change gives the user more fine-grained control over the inspector port used by individual cluster workers. Previously, cluster workers would simply increment from the master's debug port. |
- Add missing `changes:` entry - Use full sentences - Use proper indentation Ref: nodejs#14140 PR-URL: nodejs#14349 Reviewed-By: Colin Ihrig <[email protected]>
addaleax
force-pushed
the
doc-cluster-inspectport
branch
from
53ef4a0 to
a3365c6
Compare
|
Landed in a3365c6 |
Merged
addaleax
added a commit
that referenced
this pull request
Jul 18, 2017
- Add missing `changes:` entry - Use full sentences - Use proper indentation Ref: #14140 PR-URL: #14349 Reviewed-By: Colin Ihrig <[email protected]>
addaleax
added a commit
that referenced
this pull request
Jul 18, 2017
- Add missing `changes:` entry - Use full sentences - Use proper indentation Ref: #14140 PR-URL: #14349 Reviewed-By: Colin Ihrig <[email protected]>
Fishrock123
pushed a commit
that referenced
this pull request
Jul 19, 2017
- Add missing `changes:` entry - Use full sentences - Use proper indentation Ref: #14140 PR-URL: #14349 Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes:entryRef: #14140
Can we fast-track this? I noticed it while updating the 8.2.0 proposal. /cc @refack @mcollina @cjihrig
Also, the original PR was labelled as a notable change. Can I get a one- or two-sentence description of what makes it notable?