Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v6.x backport] cluster, dns, repl, tls, util: fix RegExp nits #14348

Closed
wants to merge 1 commit into from
Closed

[v6.x backport] cluster, dns, repl, tls, util: fix RegExp nits #14348

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Jul 18, 2017 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

cluster, dns, repl, tls, util

Backport of #13536

  • Take RegExp creation out of cycles.
  • Use test(), not match() in boolean context.
  • Remove redundant RegExp parts.

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. v6.x labels Jul 18, 2017
@vsemozhetbyt vsemozhetbyt mentioned this pull request Jul 18, 2017
Closed
2 tasks
@vsemozhetbyt
cluster, dns, repl, tls, util: fix RegExp nits
22ab3b7 
* Take RegExp creation out of cycles.
* Use test(), not match() in boolean context.
* Remove redundant RegExp parts.

PR-URL: #13536
Reviewed-By: Anna Henningsen <[email protected]>
@vsemozhetbyt
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/9229/

MylesBorins pushed a commit that referenced this pull request Jul 18, 2017
@vsemozhetbyt @MylesBorins
cluster, dns, repl, tls, util: fix RegExp nits
ddc8050 
* Take RegExp creation out of cycles.
* Use test(), not match() in boolean context.
* Remove redundant RegExp parts.

Backport-PR-URL: #14348
PR-URL: #13536
Reviewed-By: Anna Henningsen <[email protected]>
@MylesBorins
Copy link
Contributor

landed in ddc8050

@vsemozhetbyt vsemozhetbyt deleted the backport-13536-to-v6.x branch July 18, 2017 23:45
MylesBorins pushed a commit that referenced this pull request Jul 21, 2017
@vsemozhetbyt @MylesBorins
cluster, dns, repl, tls, util: fix RegExp nits
edbe442 
* Take RegExp creation out of cycles.
* Use test(), not match() in boolean context.
* Remove redundant RegExp parts.

Backport-PR-URL: #14348
PR-URL: #13536
Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vsemozhetbyt @MylesBorins @addaleax @nodejs-github-bot