timers: remove no longer relevant comment #14314
Conversation
nodejs-github-bot
added
the
timers
|
I don't think the comment is needed at all for v7.x+ since V8 in v7.x allows optimization of functions containing try-catch/finally, they just can't be inlined. With TurboFan it's probably even less of an issue (I have not checked inlineability with try-catch/finally there). |
|
@mscdex in that case I guess the call should be moved inside the try/finally and the comment removed? |
|
@gibfahn I'm not sure manually inlining the helper function really matters, although I haven't benchmarked the difference with TurboFan. |
There was a problem hiding this comment.
Refer to the discussion in #14308
This should probably revert the optimization altogether once we have TurboFan (do we have it by default in master? not sure lol).
The change is just extra noise otherwise. :/
Yes. :) |
|
Ping @Fishrock123 |
|
I think it would be fine to land this even if our real goal is to change the code again. This is a task marked as good first contribution and it would be good to land this as is. |
|
@Fishrock123 if you still have concerns, please respond here. Otherwise I am going to land this on Monday. |
|
@Fishrock123 thanks ❤️ |
|
Landed in a2b6872 |
PR-URL: #14314 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
PR-URL: #14314 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
PR-URL: #14314 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
PR-URL: #14314 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
PR-URL: nodejs#14314 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
This PR resolves #14308 by removing a comment that is no longer relevant.
Checklist
Affected core subsystem(s)
None. File modified is
timers, but no code was changed.