Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use regex with assert.throws #14299

Closed
wants to merge 1 commit into from
Closed

test: use regex with assert.throws #14299

wants to merge 1 commit into from

Conversation

superwoods
Copy link
Contributor

  • from JSconfCN 2017 code learn workshop

@superwoods
test: use regex with assert.throws
e875e9a 
- from JSconfCN 2017 code learn workshop
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 16, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Jul 16, 2017
Trott
Trott approved these changes Jul 16, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

benjamingr
benjamingr approved these changes Jul 16, 2017
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, given the semver-major discussion around error messages (and the likely 'yes' answer) these tests help.

@tniessen tniessen self-assigned this Jul 16, 2017
@vsemozhetbyt
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/9163/ (by @tniessen)

@Trott
Copy link
Member

Trott commented Jul 16, 2017

CI was green but I canceled some of the slower ARM devices and one of the two FreeBSD hosts to help with our current CI backlog problem. IMO the CI on this can be treated as green.

@Trott
Copy link
Member

Trott commented Jul 17, 2017

Green CI, small change, 7 or 8 approvals, fast-tracking.

Landed iin 24f79a7

Thanks for the contribution! 🎉

@Trott Trott closed this Jul 17, 2017
Trott pushed a commit to Trott/io.js that referenced this pull request Jul 17, 2017
@superwoods @Trott
test: use regex error checks in test-util-format
24f79a7 
Replace constructor with regular expression for second argument
to assert.throws() in test-util-format.

PR-URL: nodejs#14299
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@addaleax addaleax mentioned this pull request Jul 18, 2017
Merged
addaleax pushed a commit that referenced this pull request Jul 18, 2017
@superwoods @addaleax
test: use regex error checks in test-util-format
784102f 
Replace constructor with regular expression for second argument
to assert.throws() in test-util-format.

PR-URL: #14299
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Jul 19, 2017
@superwoods @Fishrock123
test: use regex error checks in test-util-format
7fc04ae 
Replace constructor with regular expression for second argument
to assert.throws() in test-util-format.

PR-URL: #14299
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
@superwoods @MylesBorins
test: use regex error checks in test-util-format
04ed186 
Replace constructor with regular expression for second argument
to assert.throws() in test-util-format.

PR-URL: #14299
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
@superwoods @MylesBorins
test: use regex error checks in test-util-format
f84a7a6 
Replace constructor with regular expression for second argument
to assert.throws() in test-util-format.

PR-URL: #14299
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 5, 2017
@superwoods @MylesBorins
test: use regex error checks in test-util-format
bbe3288 
Replace constructor with regular expression for second argument
to assert.throws() in test-util-format.

PR-URL: #14299
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
This was referenced Sep 5, 2017
Closed
Closed
This was referenced Sep 6, 2017
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@benjamingr benjamingr benjamingr approved these changes

@Trott Trott Trott approved these changes

@refack refack refack approved these changes

Assignees

@tniessen tniessen

Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.