Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsconfcn] test: replace string concatenation #14295

Closed
wants to merge 1 commit into from
Closed

[jsconfcn] test: replace string concatenation #14295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/async-hooks/test-signalwrap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ assert.strictEqual(typeof signal1.triggerAsyncId, 'number');
checkInvocations(signal1, { init: 1 }, 'when SIGUSR2 handler is set up');

let count = 0;
exec('kill -USR2 ' + process.pid);
exec(`kill -USR2 ${process.pid}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use process.kill(pid, signal) - https://nodejs.org/api/process.html#process_process_kill_pid_signal

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @refack.
It's better to use the process.kill(pid, signal), will update once I'm avaliable.


let signal2;

Expand All @@ -36,7 +36,7 @@ function onsigusr2() {
' signal1: when first SIGUSR2 handler is called for the first time');

// trigger same signal handler again
exec('kill -USR2 ' + process.pid);
exec(`kill -USR2 ${process.pid}`);
} else {
// second invocation
checkInvocations(
Expand All @@ -61,7 +61,7 @@ function onsigusr2() {
signal2, { init: 1 },
'signal2: when second SIGUSR2 handler is setup');

exec('kill -USR2 ' + process.pid);
exec(`kill -USR2 ${process.pid}`);
}
}

Expand Down