Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[code & learn]test: change style in parallel bad options #14274

Closed
wants to merge 1 commit into from
Closed

[code & learn]test: change style in parallel bad options #14274

wants to merge 1 commit into from

Conversation

boydfd
Copy link
Contributor

@boydfd boydfd commented Jul 16, 2017 •
edited
Loading

Replace string concatenation in test/parallel/test-cli-bad-options.js
with template literals.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@boydfd
test: change style in parallel bad options
8548021 
Replace string concatenation in test/parallel/test-cli-bad-options.js
with template literals.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 16, 2017
@joyeecheung joyeecheung added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Jul 16, 2017
Trott
Trott approved these changes Jul 16, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@TimothyGu TimothyGu added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. and removed code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Jul 16, 2017
evanlucas
evanlucas approved these changes Jul 16, 2017
View reviewed changes
Copy link
Contributor

@evanlucas evanlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for the contribution!!

@vsemozhetbyt
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/9162/

@Trott
Copy link
Member

Trott commented Jul 16, 2017

CI was green but I canceled some of the slower ARM hosts to help with our current CI backlog problem. IMO CI can be considered green on this, assuming the one FreeBSD host still running comes back green.

@Trott
Copy link
Member

Trott commented Jul 17, 2017

Small change, green CI, 7 approvals, fast-tracking.

Landed in 3f7216c

Thanks for the contribution! 🎉

@Trott Trott closed this Jul 17, 2017
Trott pushed a commit to Trott/io.js that referenced this pull request Jul 17, 2017
@boydfd @Trott
test: change style in test-cli-bad-options
3f7216c 
Replace string concatenation in test/parallel/test-cli-bad-options.js
with template literal. Adjust argument layout for readability.

PR-URL: nodejs#14274
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@addaleax addaleax mentioned this pull request Jul 18, 2017
Merged
addaleax pushed a commit that referenced this pull request Jul 18, 2017
@boydfd @addaleax
test: change style in test-cli-bad-options
f9b292c 
Replace string concatenation in test/parallel/test-cli-bad-options.js
with template literal. Adjust argument layout for readability.

PR-URL: #14274
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Jul 19, 2017
@boydfd @Fishrock123
test: change style in test-cli-bad-options
5d06d0b 
Replace string concatenation in test/parallel/test-cli-bad-options.js
with template literal. Adjust argument layout for readability.

PR-URL: #14274
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

@evanlucas evanlucas evanlucas approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.