Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix errorMessages regular expressions from crypto-random #14271

Closed
wants to merge 1 commit into from
Closed

test: fix errorMessages regular expressions from crypto-random #14271

wants to merge 1 commit into from

Conversation

hacke2
Copy link
Contributor

@hacke2 hacke2 commented Jul 16, 2017 •
edited
Loading

test/parallel/test-catpto-random.js contains an object called
errorMesssage that contains regular expressions.They are only partially
matching regular expressions. Make them match the entire error message.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
Affected core subsystem(s)

crypto

@hacke2
test: fix errorMessages regular expressions from crypto-random
f524a66 
test/parallel/test-catpto-random.js contains an object called
errorMesssage that contains regular expressions.They are only partially
matching regular expressions. Make them match the entire error message.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 16, 2017
Trott
Trott approved these changes Jul 16, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Jul 16, 2017
@TimothyGu TimothyGu added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. and removed code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Jul 16, 2017
@vsemozhetbyt
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/9158/

@tniessen tniessen self-assigned this Jul 16, 2017
@Trott
Copy link
Member

Trott commented Jul 16, 2017

Ci was green but canceled before the Pi 1 devices finished to help with our backlog. I think this can land. Seems trivial enough and has enough approval that it could be fast-tracked, but I see @tniessen has self-assigned so I'll let them be the judge of that. I'm OK if we choose to fast-track C + L contributions less than I've been doing the last few hours.

@Trott
Copy link
Member

Trott commented Jul 17, 2017

Small change, green CI, 5 approvals, fast-tracking.

Landed in 2bbeec7

@Trott Trott closed this Jul 17, 2017
Trott pushed a commit to Trott/io.js that referenced this pull request Jul 17, 2017
@hacke2 @Trott
test: improve regexps for error checking
2bbeec7 
test/parallel/test-catpto-random.js contains an object called
errorMesssage that contains regular expressions.They are only partially
matching regular expressions. Make them match the entire error message.

PR-URL: nodejs#14271
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@Trott
Copy link
Member

Trott commented Jul 17, 2017

Thanks for the contribution! 🎉

@tniessen
Copy link
Member

We should pay more attention to commit messages... This PR was landed with multiple typos (errorMesssage → errMessages, expressions.They → expressions. They, catpto → crypto) in the commit message. It might be a good idea to check the commit message when landing PRs @Trott, even while fast-tracking lots of them. (Sure, these are harmless mistakes, but they are easily avoidable.)

@addaleax addaleax mentioned this pull request Jul 18, 2017
Merged
addaleax pushed a commit that referenced this pull request Jul 18, 2017
@hacke2 @addaleax
test: improve regexps for error checking
f5e8342 
test/parallel/test-catpto-random.js contains an object called
errorMesssage that contains regular expressions.They are only partially
matching regular expressions. Make them match the entire error message.

PR-URL: #14271
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Jul 19, 2017
@hacke2 @Fishrock123
test: improve regexps for error checking
cb1c134 
test/parallel/test-catpto-random.js contains an object called
errorMesssage that contains regular expressions.They are only partially
matching regular expressions. Make them match the entire error message.

PR-URL: #14271
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@gibfahn gibfahn gibfahn approved these changes

Assignees

@tniessen tniessen

Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@hacke2 @vsemozhetbyt @Trott @tniessen @cjihrig @gireeshpunathil @gibfahn @MylesBorins @TimothyGu @nodejs-github-bot