tools: delete an unused argument #14251
Conversation
|
Thanks for the contribution! 🎉 |
|
@Trott What about changing |
You mean just in the Pretty sure we'll still have tons of errors in |
|
@Trott I shall do some churn proposals soon, including this one. |
Guess I'll have to find some other source of super-easy first contributions for Code + Learn attendees! 😆 |
|
They will be issue proposals, not PR, so you will be able to use them if there will be some consensus) |
I was half-joking, but truth be told, I was planning on giving some of those out at Code + Learn tomorrow if I run out of other issues (which I don't expect to happen, but it's always good to be prepared!). |
Doing them all at once is the same amount of code churn, but it's a lot less PR churn. Unless we're doing them in code-and-learns (in which case it's fine), I'd prefer it all at once. It's also easier for backporting (if the person is willing to raise a backport PR). |
|
Landed in 2e91d8d, thank you for your contribution and welcome aboard! 🎉 |
PR-URL: #14251 Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs/node#14251 Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #14251 Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #14251 Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #14251 Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Delete the argument never being used.
make -j4 test(UNIX), orvcbuild test(Windows) passes