Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update configure to require g++ 4.9.4 #14204

Closed
wants to merge 1 commit into from
Closed

doc: update configure to require g++ 4.9.4 #14204

wants to merge 1 commit into from

Conversation

cxreg
Copy link
Contributor

@cxreg cxreg commented Jul 12, 2017 •
edited by refack
Loading

d13a65a bumped the g++ requirement to 4.9.4 but configure is not enforcing it. Update configure to correctly detect this.

/cc @nodejs/build

Checklist

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Jul 12, 2017
addaleax
addaleax approved these changes Jul 12, 2017
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I’m okay with not letting this wait 48 hours.

@refack
Copy link
Contributor

refack commented Jul 12, 2017

+1 on expedition

@refack
Copy link
Contributor

refack commented Jul 12, 2017

Quick test on linuxONE: https://ci.nodejs.org/job/node-test-commit-linuxone/7247/

cjihrig
cjihrig approved these changes Jul 12, 2017
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. CI was green.

@mhdawson
Copy link
Member

mhdawson commented Jul 13, 2017 •
edited
Loading

I think a run to validate we have the compiler across all machines makes sense as well. CI does not seem to have much of a backlog right now.

https://ci.nodejs.org/job/node-test-pull-request/9116/

@mhdawson
Copy link
Member

Will this actually fail to build or just generate a warning ?

bnoordhuis
bnoordhuis approved these changes Jul 13, 2017
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson Prints a warning.

@mhdawson
Copy link
Member

@bnoordhuis thats what I thought, I guess running the CI across platforms will not necessarily tell us if we've upgraded them all or not.

@BridgeAR
Copy link
Member

Landed in 79773f8

@BridgeAR BridgeAR closed this Aug 28, 2017
BridgeAR pushed a commit that referenced this pull request Aug 28, 2017
@BridgeAR
doc: update configure to require g++ 4.9.4
79773f8 
PR-URL: #14204
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
ghost pushed a commit to ayojs/ayo that referenced this pull request Aug 30, 2017
doc: update configure to require g++ 4.9.4
c85c9dc 
PR-URL: nodejs/node#14204
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
ghost pushed a commit to ayojs/ayo that referenced this pull request Aug 30, 2017
doc: update configure to require g++ 4.9.4
cd91754 
PR-URL: nodejs/node#14204
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
@MylesBorins
doc: update configure to require g++ 4.9.4
022ce73 
PR-URL: #14204
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Sep 10, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
@MylesBorins
doc: update configure to require g++ 4.9.4
a524285 
PR-URL: #14204
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@cxreg @refack @mhdawson @BridgeAR @bnoordhuis @jasnell @addaleax @cjihrig @tniessen @nodejs-github-bot