tools: increase test timeouts #14197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least temporarily until snapshots are restored, increase timeout for tests. Tests that spawn many processes are timing out across many platforms on CI.
Trott
added
test
nodejs-github-bot
added
test
refack
approved these changes
Jul 12, 2017
lpinca
approved these changes
Jul 12, 2017
|
OMG, this got a green for the Raspberry Pi 1 devices! I'd like to expedite this, like we've been doing for other "fix CI problems stemming from the recent changes" PRs we've been doing. @nodejs/testing |
|
@Trott I'd say expediting is the right way to go. |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jul 12, 2017
At least temporarily until snapshots are restored, increase timeout for tests. Tests that spawn many processes are timing out across many platforms on CI. PR-URL: nodejs#14197 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
|
Landed in 76fa6b2 |
|
Post-land CI was green. I can't believe it! https://ci.nodejs.org/job/node-test-commit/11091/ |
|
Even had a tiny plinux miracle |
Merged
addaleax
pushed a commit
that referenced
this pull request
Jul 18, 2017
At least temporarily until snapshots are restored, increase timeout for tests. Tests that spawn many processes are timing out across many platforms on CI. PR-URL: #14197 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Fishrock123
pushed a commit
that referenced
this pull request
Jul 19, 2017
At least temporarily until snapshots are restored, increase timeout for tests. Tests that spawn many processes are timing out across many platforms on CI. PR-URL: #14197 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least temporarily until snapshots are restored, increase timeout for
tests. Tests that spawn many processes are timing out across many
platforms on CI.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
tools test