domain: add soft deprecation notice #141
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the TC meeting on 2014-12-10, domains will be "soft deprecated" until a suitable replacement API is available; at which time they will be fully deprecated. Full deprecation will include references to replacement API and the application of util.deprecate to the domain api.
|
LGTM |
| // WARNING: THIS MODULE IS PENDING DEPRECATION. | ||
| // | ||
| // No new pull requests targetting this module will be accepted | ||
| // unless they are address existing, critical bugs. |
|
👍 |
|
I wish we could outline some of the problems in here but I think they are too numerous and detailed to enumerate. If you do a google search for "node.js domains" the results are almost all positive. Anyway, this is good enough for now, perhaps someone will write a great article on this that we can link to. So LGTM. |
|
LGTM |
chrisdickinson
added a commit
that referenced
this pull request
Dec 12, 2014
Per the TC meeting on 2014-12-10, domains will be "soft deprecated" until a suitable replacement API is available; at which time they will be fully deprecated. Full deprecation will include references to replacement API and the application of util.deprecate to the domain api. PR-URL: #141 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
|
Merged in 6a29356. |
This was referenced Feb 11, 2024
This was referenced Feb 11, 2024
This was referenced Feb 11, 2024
This was referenced Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the TC meeting on 2014-12-10, domains will be "soft deprecated"
until a suitable replacement API is available; at which time they
will be fully deprecated. Full deprecation will include references
to replacement API and the application of util.deprecate to the domain
api.
R=@piscisaureus @rvagg