process: use internal/errors in internalNextTick #13982
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
process
tniessen
added
the
errors
80 tasks
jasnell
approved these changes
Jun 30, 2017
lpinca
approved these changes
Jun 30, 2017
|
Landed in 3129b2c |
tniessen
added a commit
that referenced
this pull request
Jul 2, 2017
PR-URL: #13982 Refs: #12892 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Jul 3, 2017
PR-URL: nodejs#13982 Refs: nodejs#12892 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
|
@jasnell I think this should have been marked as SemVer major, will add please remove if thats incorrect. |
mhdawson
added
the
semver-major
addaleax
pushed a commit
that referenced
this pull request
Jul 11, 2017
PR-URL: #13982 Refs: #12892 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Jul 18, 2017
PR-URL: #13982 Refs: #12892 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #12892
Refs: #11273
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
process