test: refactor test-fs-options-immutable #13977
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
fs
jasnell
approved these changes
Jun 29, 2017
lpinca
approved these changes
Jun 29, 2017
|
Also add a |
cjihrig
approved these changes
Jun 29, 2017
refack
approved these changes
Jun 29, 2017
* Reorder require() statements per test-writing guide * Use common.mustNotCall() to check that callback is not invoked * Use common.mustCall() to check that callback is invoked
Trott
force-pushed
the
refactor-test-fs-options-immutable
branch
from
e14c2d1
to
1021aeb
Compare
|
Addressed nit. CI: https://ci.nodejs.org/job/node-test-pull-request/8882/ |
richardlau
approved these changes
Jun 29, 2017
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jul 2, 2017
* Reorder require() statements per test-writing guide * Use common.mustNotCall() to check that callback is not invoked * Use common.mustCall() to check that callback is invoked PR-URL: nodejs#13977 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]>
|
Landed in f05653d |
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Jul 3, 2017
* Reorder require() statements per test-writing guide * Use common.mustNotCall() to check that callback is not invoked * Use common.mustCall() to check that callback is invoked PR-URL: nodejs#13977 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
addaleax
pushed a commit
that referenced
this pull request
Jul 11, 2017
* Reorder require() statements per test-writing guide * Use common.mustNotCall() to check that callback is not invoked * Use common.mustCall() to check that callback is invoked PR-URL: #13977 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Jul 18, 2017
* Reorder require() statements per test-writing guide * Use common.mustNotCall() to check that callback is not invoked * Use common.mustCall() to check that callback is invoked PR-URL: #13977 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test fs