Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

n-api: fix section title typo #13972

Closed
wants to merge 1 commit into from
Closed

n-api: fix section title typo #13972

wants to merge 1 commit into from

Conversation

kfarnung
Copy link
Contributor

Checklist
Affected core subsystem(s)

n-api

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. labels Jun 28, 2017
@kfarnung
Copy link
Contributor Author

kfarnung commented Jun 28, 2017 •
edited
Loading

/cc @mhdawson @jasongin

jasnell
jasnell approved these changes Jun 29, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't need to wait the 48 hours to land

jasnell pushed a commit that referenced this pull request Jun 29, 2017
@kfarnung @jasnell
n-api: fix section title typo
a71d205 
PR-URL: #13972
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Jun 29, 2017

Landed in a71d205

@jasnell jasnell closed this Jun 29, 2017
@kfarnung kfarnung deleted the patch-1 branch June 29, 2017 06:13
addaleax pushed a commit that referenced this pull request Jun 29, 2017
@kfarnung @addaleax
n-api: fix section title typo
690e0e9 
PR-URL: #13972
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@addaleax addaleax mentioned this pull request Jun 29, 2017
Merged
addaleax pushed a commit that referenced this pull request Jul 11, 2017
@kfarnung @addaleax
n-api: fix section title typo
c6602f1 
PR-URL: #13972
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Jul 18, 2017
@kfarnung @addaleax
n-api: fix section title typo
4843d4d 
PR-URL: #13972
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 10, 2018
@kfarnung
n-api: fix section title typo
947b1cd 
PR-URL: nodejs#13972
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
@kfarnung @MylesBorins
n-api: fix section title typo
97b628b 
Backport-PR-URL: #19447
PR-URL: #13972
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kfarnung @jasnell @cjihrig @richardlau @vsemozhetbyt @MylesBorins @nodejs-github-bot