errors, url: port url errors to internal/errors #13963
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
url
|
CI: https://ci.nodejs.org/job/node-test-pull-request/8857/ Don't worry if node-test-commit-linux doesn't pass. The CI bot has had some trouble recently. |
refack
approved these changes
Jun 29, 2017
refack
added
errors
jasnell
reviewed
Jun 29, 2017
| code: 'ERR_INVALID_ARG_TYPE', | ||
| type: TypeError, | ||
| message: 'The "urlObj" argument must be of type object. ' + | ||
| `Received type ${type}` |
jasnell
reviewed
Jun 29, 2017
| }); | ||
|
|
||
| assert.throws(() => { url.parse('http://%E0%A4%A@fail'); }, | ||
| /^URIError: URI malformed$/); | ||
| assert.throws(() => { url.parse('http://%E0%A4%A@fail'); }, /^URIError: URI malformed$/); |
starkwang
force-pushed
the
url-internal-error
branch
from
e0d434d
to
9e4763b
Compare
starkwang
force-pushed
the
url-internal-error
branch
from
9e4763b
to
b630e47
Compare
TimothyGu
approved these changes
Jun 29, 2017
80 tasks
jasnell
approved these changes
Jun 30, 2017
refack
pushed a commit
to refack/node
that referenced
this pull request
Jul 2, 2017
PR-URL: nodejs#13963 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 473f0ef |
|
Extra sanity run on |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is already a PR (#11360) for this migration, but it seems to be out-of-date and deprecated. So I make a new one.
Ref: #11273
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
url, test