test: add check on an addon that doesn't register #13954
Conversation
nodejs-github-bot
added
addons
test/addons/not-a-binding/test.js
Outdated
| const common = require('../../common'); | ||
| const assert = require('assert'); | ||
|
|
||
| const re = new RegExp('Module did not self-register'); |
There was a problem hiding this comment.
Can you use ^ and $ to make sure the entire error message is being matched.
There was a problem hiding this comment.
@cjihrig done.
ezequielgarcia
force-pushed
the
test_not_a_binding
branch
from
e3fd9ca
to
1a5b353
Compare
test/addons/not-a-binding/test.js
Outdated
| const assert = require('assert'); | ||
|
|
||
| const re = new RegExp('^Error: Module did not self-register\\.$'); | ||
| assert.throws(() => require(`./build/${common.buildType}/binding`), re); |
There was a problem hiding this comment.
Out of curiosity, what is the reason for using a regexp object instead of a regexp literal?
There was a problem hiding this comment.
No reason, just that I used the node-module-version test as model.
There was a problem hiding this comment.
I'd generally prefer the regexp literal form.
This commit calls require on a shared library that is not declared as a node module, and therefore does not register properly. Signed-off-by: Ezequiel Garcia <[email protected]>
ezequielgarcia
force-pushed
the
test_not_a_binding
branch
from
1a5b353
to
1db7836
Compare
|
Agreed. Changed to literal. |
|
Looks like there are linting issues that need to be fixed. |
|
@jasnell I don't have read permissions, my user is ezequielgarcia. I'll run the linter and update. |
|
Access to the CI environment is temporarily blocked while testing a number of security fixes. |
Try now 😁 |
|
@jasnell according to https://ci.nodejs.org/job/node-test-linter/10386/console, there was some git errors...
or am I looking the wrong place? |
|
@ezequielgarcia that one looks like a transient issue, rerunning: |
|
Pre-land CI: https://ci.nodejs.org/job/node-test-pull-request/9432/ Assuming there are no objections from @bnoordhuis @jasnell @cjihrig @mhdawson ... ? |
|
No objections, still LGTM. |
|
|
|
still lgtm |
|
Landed in 13d6eae, thank you! |
This commit calls require on a shared library that is not declared as a node module, and therefore does not register properly. PR-URL: #13954 Signed-off-by: Ezequiel Garcia <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
This commit calls require on a shared library that is not declared as a node module, and therefore does not register properly. PR-URL: #13954 Signed-off-by: Ezequiel Garcia <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
This commit calls require on a shared library that is not declared as a node module, and therefore does not register properly. PR-URL: #13954 Signed-off-by: Ezequiel Garcia <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
This commit calls require on a shared library that is not declared as a node module, and therefore does not register properly. PR-URL: #13954 Signed-off-by: Ezequiel Garcia <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
This commit calls require on a shared library that is not declared as a node module, and therefore does not register properly. PR-URL: #13954 Signed-off-by: Ezequiel Garcia <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
This commit calls require on a shared library that is not declared as a node module, and therefore does not register properly. PR-URL: #13954 Signed-off-by: Ezequiel Garcia <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
This test
require()s a shared library that won't register as a node module.Other tests would be possible such as loading a file that is not a shared library, or loading a path that doesn't exist. However, these two tests produce platform-dependent error messages, and so I haven't included them.
Checklist
make -j4 test(UNIX) passesAffected core subsystem(s)
test