Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readline: fix character width calculation #13918

Closed
wants to merge 2 commits into from
Closed

readline: fix character width calculation #13918

wants to merge 2 commits into from

Commits on Jun 27, 2017

  1. readline: properly handle 0-width characters

    @TimothyGu
    TimothyGu committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    8a3e46a View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2017

  1. src: revise character width calculation 

    - Categorize all nonspacing marks (Mn) and enclosing marks (Me) as
  0-width
- Categorize all spacing marks (Mc) as non-0-width.
- Treat soft hyphens (a format character Cf) as non-0-width.
- Do not treat all unassigned code points as 0-width; instead, let ICU
  select the default for that character per UAX nodejs#11.
- Avoid getting the General_Category of a character multiple times as it
  is an intensive operation.

Refs: http://unicode.org/reports/tr11/
    @TimothyGu
    TimothyGu committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    6e9fdd8 View commit details
    Browse the repository at this point in the history