-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: refactor test-vm-sigint #13902
Conversation
* Use common.mustNotCall() to confirm SIGINT listeners are not being invoked. * Improve assertion check on integer child argument. * Add blank line per test writing guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only test failure looks unrelated.
Closed in 99dc9d0 |
* Use common.mustNotCall() to confirm SIGINT listeners are not being invoked. * Improve assertion check on integer child argument. * Add blank line per test writing guide. PR-URL: #13902 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>
* Use common.mustNotCall() to confirm SIGINT listeners are not being invoked. * Improve assertion check on integer child argument. * Add blank line per test writing guide. PR-URL: #13902 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>
* Use common.mustNotCall() to confirm SIGINT listeners are not being invoked. * Improve assertion check on integer child argument. * Add blank line per test writing guide. PR-URL: #13902 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>
* Use common.mustNotCall() to confirm SIGINT listeners are not being invoked. * Improve assertion check on integer child argument. * Add blank line per test writing guide. PR-URL: #13902 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>
This does not land cleanly in LTS. Please feel free to manually backport by following the guide. Please also feel free to replace do-not-land if it is being backported It is worth mentioning that after fixing the conflicts there were a bunch of errors on v6.x
=== release test-vm-sigint ===
Path: parallel/test-vm-sigint
/Users/mborins/code/node/v6.x/test/parallel/test-vm-sigint.js:23
assert.ok(Number.isInteger(listeners));
^
ReferenceError: listeners is not defined ReferenceError: listeners is not defined assert.js:81 |
invoked.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
test vm