Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor indexOf uses to es6 equivalents #13853

Closed
wants to merge 1 commit into from

Conversation

Bnaya
Copy link

@Bnaya Bnaya commented Jun 21, 2017

refactor indexOf uses to es6 where applicable

Refs: #12586

#goodnessSquad

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 21, 2017
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Please feel free to also give us any feedback about the onboarding process today.

#goodnessSquad

@vsemozhetbyt
Copy link
Contributor

continue;

const frame = line.substr(line.indexOf(sentinel) + sentinel.length);
const top = frames.shift();

assert.strictEqual(frame.indexOf(top), 0,
assert.ok(frame.startsWith(top) === true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The === true part can be left out here.

continue;

const frame = line.substr(line.indexOf(sentinel) + sentinel.length);
const top = frames.shift();

assert.strictEqual(frame.indexOf(top), 0,
assert.ok(frame.startsWith(top) === true,
`unexpected frame where ${top} was expected`);
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt Jun 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is now linter issue:

 96:24  error  Expected indentation of 14 spaces but found 23  indent-legacy

Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits addressed.

refactor indexOf uses to es6 where applicable

Refs: nodejs#12586
@Bnaya
Copy link
Author

Bnaya commented Jun 21, 2017

I've fixed the rejects, how do i make the CI run again?

@vsemozhetbyt
Copy link
Contributor

Copy link
Contributor

@aqrln aqrln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. CI failure on linux-fips is unrelated.

@tniessen
Copy link
Member

tniessen commented Jul 2, 2017

I think these changes were already covered in #13852 (amongst others) 😕 . Thank you for your contribution, I am sorry these changes did not make it in. Keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants