-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: clean up config_fips.gypi #13837
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when configuring the project using --openssl-fips a gyp include file name config_fips.gypi will be created. If the project is later configured but without the --openssl-fips flag an error will occur. For example: $ ./configure --openssl-fips=bogus $ ./configure && make -j8 ... /node/deps/openssl/fips/fipsld: line 8: /bin/fipsld: No such file or directory Error 127 This commit suggests removing the generate config_fips.gypi when the --openssl-fips flag is not give on the command line.
nodejs-github-bot
added
the
build
Issues and PRs related to build files or the CI.
label
Jun 21, 2017
I tried to find where |
It is used in tools/gyp_node.py. |
Thanks! (Found a bug in my IDE, the "search in excluded directories" does not work as expected) |
refack
approved these changes
Jun 21, 2017
cjihrig
approved these changes
Jun 21, 2017
jasnell
approved these changes
Jun 22, 2017
danbev
added a commit
to danbev/node
that referenced
this pull request
Jun 24, 2017
Currently when configuring the project using --openssl-fips a gyp include file name config_fips.gypi will be created. If the project is later configured but without the --openssl-fips flag an error will occur. For example: $ ./configure --openssl-fips=bogus $ ./configure && make -j8 ... /node/deps/openssl/fips/fipsld: line 8: /bin/fipsld: No such file or directory Error 127 This commit suggests removing the generate config_fips.gypi when the --openssl-fips flag is not give on the command line. PR-URL: nodejs#13837 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Landed in 748b2a8 |
addaleax
pushed a commit
that referenced
this pull request
Jun 24, 2017
Currently when configuring the project using --openssl-fips a gyp include file name config_fips.gypi will be created. If the project is later configured but without the --openssl-fips flag an error will occur. For example: $ ./configure --openssl-fips=bogus $ ./configure && make -j8 ... /node/deps/openssl/fips/fipsld: line 8: /bin/fipsld: No such file or directory Error 127 This commit suggests removing the generate config_fips.gypi when the --openssl-fips flag is not give on the command line. PR-URL: #13837 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
addaleax
pushed a commit
that referenced
this pull request
Jun 29, 2017
Currently when configuring the project using --openssl-fips a gyp include file name config_fips.gypi will be created. If the project is later configured but without the --openssl-fips flag an error will occur. For example: $ ./configure --openssl-fips=bogus $ ./configure && make -j8 ... /node/deps/openssl/fips/fipsld: line 8: /bin/fipsld: No such file or directory Error 127 This commit suggests removing the generate config_fips.gypi when the --openssl-fips flag is not give on the command line. PR-URL: #13837 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Jul 11, 2017
Currently when configuring the project using --openssl-fips a gyp include file name config_fips.gypi will be created. If the project is later configured but without the --openssl-fips flag an error will occur. For example: $ ./configure --openssl-fips=bogus $ ./configure && make -j8 ... /node/deps/openssl/fips/fipsld: line 8: /bin/fipsld: No such file or directory Error 127 This commit suggests removing the generate config_fips.gypi when the --openssl-fips flag is not give on the command line. PR-URL: #13837 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Jul 18, 2017
Currently when configuring the project using --openssl-fips a gyp include file name config_fips.gypi will be created. If the project is later configured but without the --openssl-fips flag an error will occur. For example: $ ./configure --openssl-fips=bogus $ ./configure && make -j8 ... /node/deps/openssl/fips/fipsld: line 8: /bin/fipsld: No such file or directory Error 127 This commit suggests removing the generate config_fips.gypi when the --openssl-fips flag is not give on the command line. PR-URL: #13837 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 14, 2017
Currently when configuring the project using --openssl-fips a gyp include file name config_fips.gypi will be created. If the project is later configured but without the --openssl-fips flag an error will occur. For example: $ ./configure --openssl-fips=bogus $ ./configure && make -j8 ... /node/deps/openssl/fips/fipsld: line 8: /bin/fipsld: No such file or directory Error 127 This commit suggests removing the generate config_fips.gypi when the --openssl-fips flag is not give on the command line. PR-URL: #13837 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 15, 2017
Currently when configuring the project using --openssl-fips a gyp include file name config_fips.gypi will be created. If the project is later configured but without the --openssl-fips flag an error will occur. For example: $ ./configure --openssl-fips=bogus $ ./configure && make -j8 ... /node/deps/openssl/fips/fipsld: line 8: /bin/fipsld: No such file or directory Error 127 This commit suggests removing the generate config_fips.gypi when the --openssl-fips flag is not give on the command line. PR-URL: #13837 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 16, 2017
Currently when configuring the project using --openssl-fips a gyp include file name config_fips.gypi will be created. If the project is later configured but without the --openssl-fips flag an error will occur. For example: $ ./configure --openssl-fips=bogus $ ./configure && make -j8 ... /node/deps/openssl/fips/fipsld: line 8: /bin/fipsld: No such file or directory Error 127 This commit suggests removing the generate config_fips.gypi when the --openssl-fips flag is not give on the command line. PR-URL: #13837 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
refack
added
the
embedding
Issues and PRs related to embedding Node.js in another project.
label
Aug 17, 2017
This was referenced Sep 5, 2017
This was referenced Sep 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when configuring the project using --openssl-fips a gyp
include file name config_fips.gypi will be created. If the project is
later configured but without the --openssl-fips flag an error will
occur. For example:
This commit suggests removing the generate config_fips.gypi when the
--openssl-fips flag is not give on the command line.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
build