stream: fix undefined in Readable object mode
#13760
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes `this.push(undefined)`. Fixes: nodejs#13753
addaleax
added
dont-land-on-v4.x
stream
nodejs-github-bot
added
the
stream
|
CI failure is unrelated, see #13527. |
cjihrig
approved these changes
Jun 18, 2017
calvinmetcalf
approved these changes
Jun 19, 2017
|
Landed in 9a655e9 |
addaleax
added a commit
that referenced
this pull request
Jun 21, 2017
Fixes `this.push(undefined)`. Fixes: #13753 PR-URL: #13760 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Calvin Metcalf <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Merged
addaleax
added a commit
that referenced
this pull request
Jun 21, 2017
Fixes `this.push(undefined)`. Fixes: #13753 PR-URL: #13760 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Calvin Metcalf <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Merged
addaleax
added a commit
that referenced
this pull request
Jun 24, 2017
Notable changes
* **Stream**
Two regressions with the `stream` module have been fixed:
* The `finish` event will now always be emitted after the `error` event
if one is emitted:
[[`0a9e96e86c`](0a9e96e86c)]
[#13850](#13850)
* In object mode, readable streams can now use `undefined` again.
[[`5840138e70`](5840138e70)]
[#13760](#13760)
rvagg
added a commit
that referenced
this pull request
Jun 29, 2017
Notable changes
* **Stream**
Two regressions with the `stream` module have been fixed:
* The `finish` event will now always be emitted after the `error` event
if one is emitted:
[[`0a9e96e86c`](0a9e96e86c)]
[#13850](#13850)
* In object mode, readable streams can now use `undefined` again.
[[`5840138e70`](5840138e70)]
[#13760](#13760)
rvagg
added a commit
that referenced
this pull request
Jun 29, 2017
Notable changes
* **Stream**
Two regressions with the `stream` module have been fixed:
* The `finish` event will now always be emitted after the `error` event
if one is emitted:
[[`0a9e96e86c`](0a9e96e86c)]
[#13850](#13850)
* In object mode, readable streams can now use `undefined` again.
[[`5840138e70`](5840138e70)]
[#13760](#13760)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
this.push(undefined).Fixes: #13753
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
stream
/cc @nodejs/streams