test: remove common module from test it thwarts #13748
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
console
refack
approved these changes
Jun 17, 2017
gibfahn
approved these changes
Jun 17, 2017
lpinca
reviewed
Jun 18, 2017
|
|
||
| process.on('warning', function(warning) { | ||
| process.on('warning', (warning) => { |
There was a problem hiding this comment.
Nit: I would remove the warning argument as it is not used. Also there is no guarantee that this listener is called. Should we assert that in a process.on('exit') listener?
There was a problem hiding this comment.
@lpinca Ack, done on both.
lpinca
approved these changes
Jun 18, 2017
test-global-console-exists cannot use the common module as explained in a comment but it was included later anyway. This change removes it.
jasnell
approved these changes
Jun 19, 2017
|
Sole CI failure is unrelated flaky test. |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jun 23, 2017
test-global-console-exists cannot use the common module as explained in a comment but it was included later anyway. This change removes it. PR-URL: nodejs#13748 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 4885982 |
Merged
addaleax
pushed a commit
that referenced
this pull request
Jun 24, 2017
test-global-console-exists cannot use the common module as explained in a comment but it was included later anyway. This change removes it. PR-URL: #13748 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
This was referenced Apr 28, 2023
This was referenced Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-global-console-exists cannot use the common module as explained in
a comment but it was included later anyway. This change removes it.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test console