doc: fixes a typo in the async_hooks documentation #13666
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
async_hooks
refack
approved these changes
Jun 13, 2017
|
Minor nit to whomever lands this, 'fixes:' should probably be 'Fixes:' in the commit message. Otherwise LGTM. |
chris--young
force-pushed
the
async-doc-typo
branch
from
01f9ad7
to
fb7ca40
Compare
chris--young
changed the title
> Generally it will correspond the name of the resource's constructor. should read "will correspond with..." Fixes: nodejs#13663
chris--young
force-pushed
the
async-doc-typo
branch
from
fb7ca40
to
dff842a
Compare
chris--young
changed the title
cjihrig
approved these changes
Jun 14, 2017
TimothyGu
reviewed
Jun 14, 2017
doc/api/async_hooks.md
Outdated
| @@ -192,8 +192,8 @@ Every new resource is assigned a unique ID. | |||
| ###### `type` | |||
|
|
|||
| The `type` is a string that represents the type of resource that caused | |||
| `init` to be called. Generally it will correspond the name of the resource's | |||
| constructor. | |||
| `init` to be called. Generally it will correspond with the name of the | |||
There was a problem hiding this comment.
While we're in here, can you put a comma after Generally?
> Generally it will correspond the name of the resource's constructor. should read "Generally, it will correspond to the name..." Fixes: nodejs#13663
refack
approved these changes
Jun 14, 2017
jasnell
approved these changes
Jun 15, 2017
tniessen
approved these changes
Jun 15, 2017
|
Landed in 386f53f, thank you for your first contribution! 🎉 |
tniessen
pushed a commit
that referenced
this pull request
Jun 15, 2017
> Generally it will correspond the name of the resource's constructor. should read "Generally, it will correspond to the name..." PR-URL: #13666 Fixes: #13663 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Jun 17, 2017
> Generally it will correspond the name of the resource's constructor. should read "Generally, it will correspond to the name..." PR-URL: #13666 Fixes: #13663 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
Merged
addaleax
pushed a commit
that referenced
this pull request
Jun 21, 2017
> Generally it will correspond the name of the resource's constructor. should read "Generally, it will correspond to the name..." PR-URL: #13666 Fixes: #13663 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a minor typo as described by @mscdex in #13663
should read "will correspond with..."
fixes: #13663
Checklist
Affected core subsystem(s)
doc