Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: correct typo in createSecureContext #13653

Closed
wants to merge 1 commit into from
Closed

lib: correct typo in createSecureContext #13653

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Jun 13, 2017

Minor correction in the comment regarding ssl_set_pkey.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

lib

@danbev
lib: correct typo in createSecureContext
e344d0e 
Minor correction in the comment regarding ssl_set_pkey.
@nodejs-github-bot nodejs-github-bot added the tls Issues and PRs related to the tls subsystem. label Jun 13, 2017
jasnell
jasnell approved these changes Jun 13, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This does not need to wait the 48 hours to land

jasnell pushed a commit that referenced this pull request Jun 13, 2017
@danbev @jasnell
lib: correct typo in createSecureContext
e5a4948 
Minor correction in the comment regarding ssl_set_pkey.

PR-URL: #13653
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Jun 13, 2017

Landed in e5a4948

@jasnell jasnell closed this Jun 13, 2017
addaleax pushed a commit that referenced this pull request Jun 17, 2017
@danbev @addaleax
lib: correct typo in createSecureContext
b968124 
Minor correction in the comment regarding ssl_set_pkey.

PR-URL: #13653
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@addaleax addaleax mentioned this pull request Jun 17, 2017
Merged
addaleax pushed a commit that referenced this pull request Jun 21, 2017
@danbev @addaleax
lib: correct typo in createSecureContext
cbe7c5c 
Minor correction in the comment regarding ssl_set_pkey.

PR-URL: #13653
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@addaleax addaleax mentioned this pull request Jun 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Jul 17, 2017
@danbev @MylesBorins
lib: correct typo in createSecureContext
5eb11ba 
Minor correction in the comment regarding ssl_set_pkey.

PR-URL: #13653
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jul 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@evanlucas evanlucas evanlucas approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@danbev @jasnell @evanlucas @lpinca @cjihrig @vsemozhetbyt @gibfahn @MylesBorins @nodejs-github-bot