test: refactor test-fs-read-stream-inherit #13618
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* block scope `paused` * change name of block-scoped `file3` etc. to `file` * alphabetize modules * confirm contents provided in `data` callback * confirm `data` callbacks will not fire on tests for errors
Trott
added
fs
lpinca
approved these changes
Jun 12, 2017
tniessen
reviewed
Jun 12, 2017
| file3.on('data', function(data) { | ||
| const file = fs.createReadStream(fn, Object.create({encoding: 'utf8'})); | ||
| file.length = 0; | ||
| file.on('data', function(data) { |
There was a problem hiding this comment.
Do we have any preferences whether to use lambdas or good old function declarations when they are interchangeable?
There was a problem hiding this comment.
By lambdas you mean () => {} (fat arrow) functions? I don't think we have an official policy (although I personally prefer fat arrow functions because they seem simpler).
There was a problem hiding this comment.
@gibfahn Exactly, that would be my preference as well.
refack
approved these changes
Jun 12, 2017
| file5.on('end', common.mustCall(function() { | ||
| assert.strictEqual(file5.data, 'yz\n'); | ||
| file.on('end', common.mustCall(function() { | ||
| assert.strictEqual(file.data, 'yz\n'); |
There was a problem hiding this comment.
If you're here could you parameterize the 'yz\n', here and in L106
| file7Next(); | ||
| assert(!file.closed); | ||
| assert(!file.destroyed); | ||
| assert.strictEqual(data, 'xyz\n'); |
| file7.data = ''; | ||
| file7.on('data', function(data) { | ||
| file7.data += data; | ||
| file = fs.createReadStream(null, Object.create({fd: file.fd, start: 0 })); |
There was a problem hiding this comment.
this is just weird, shadowing file but AFAICT only affects L147-8 , so there it asserts the state of this file 🤔
IMHO it's wrong, but maybe not for this PR...
cjihrig
approved these changes
Jun 12, 2017
jasnell
approved these changes
Jun 13, 2017
|
Landed in 3c506af |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jun 14, 2017
* block scope `paused` * change name of block-scoped `file3` etc. to `file` * alphabetize modules * confirm contents provided in `data` callback * confirm `data` callbacks will not fire on tests for errors PR-URL: nodejs#13618 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Jun 17, 2017
* block scope `paused` * change name of block-scoped `file3` etc. to `file` * alphabetize modules * confirm contents provided in `data` callback * confirm `data` callbacks will not fire on tests for errors PR-URL: #13618 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
addaleax
pushed a commit
that referenced
this pull request
Jun 21, 2017
* block scope `paused` * change name of block-scoped `file3` etc. to `file` * alphabetize modules * confirm contents provided in `data` callback * confirm `data` callbacks will not fire on tests for errors PR-URL: #13618 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
|
This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pausedfile3etc. tofiledatacallbackdatacallbacks will not fire on tests for errorsChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test fs