-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: improve async-hooks/test-callback-error #13559
Conversation
Will this conflict w/ #13554 ? |
Somewhat, but we're both trying to stabilize it. |
@refack On the stress test, you might want to include |
From my manual inspection if all's well it should complete quite quick |
Restressing with |
If you are working on this then please also add the if (process.argv[2]) {
// child
} else {
// parent with assert
} such we don't depend on the test to work (child must throw) for it not to fork recursively. |
Added |
ebd2443
to
13818d3
Compare
9c5f6d9
to
0ad744d
Compare
The only relation between Comparing with |
/cc @DavidCai1993 |
a01c9d6
to
e351560
Compare
Stress passed. PTAL. |
@Trott something changed. CI stopped repoducing |
0889b3c
to
a5a53a4
Compare
@rvagg is it possible that the outage (nodejs/build#749) fixed this? |
|
4171adb
to
3185544
Compare
So all but one machines passed 2 async-hooks/test-callback-error
duration_ms 0.761
severity fail
stack |-
assert.js:60
throw new errors.AssertionError({
^
AssertionError [ERR_ASSERTION]: 'SIGSEGV' === 'SIGABRT'
at ChildProcess.child.on (/home/iojs/build/workspace/node-test-commit-linux/nodes/ubuntu1604_docker_alpine34-64/test/async-hooks/test-callback-error.js:98:14)
at emitTwo (events.js:125:13)
at ChildProcess.emit (events.js:213:7)
at maybeClose (internal/child_process.js:898:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:209:5) Is this a bug or an acceptable value? |
Rerunning |
So it's consistent but it's |
Added bail clause if |
7d4eac2
to
5d01063
Compare
Once more on linux: https://ci.nodejs.org/job/node-test-commit-linux/10712/ |
5d01063
to
32c7f11
Compare
Extra sanity of |
Seems like the test is now failing every single time rather than intermittently. For me at least, @nodejs/platform-macos |
Repeating what I said in another issue: Just to be clear: No shame intended! A lot of great work has happened so far and some really important information has been uncovered. These things happen. |
Most of the work that gone into this PR was to allow for a more informative fails... |
@refack - sorry, I missed my mention in the PR. SIGSEGV seems to be unexpected, and I have seen this in AIX as well which is identified as a memory corruption. Working on some plans to track the offending code at the moment. Where should we track the Linux failure? |
I've opened #13865. commented that maybe that how |
PR-URL: #13559 Fixes: #13527 Reviewed-By: Andreas Madsen <[email protected]>
PR-URL: #13559 Fixes: #13527 Reviewed-By: Andreas Madsen <[email protected]>
PR-URL: #13559 Fixes: #13527 Reviewed-By: Andreas Madsen <[email protected]>
PR-URL: #13559 Fixes: #13527 Reviewed-By: Andreas Madsen <[email protected]>
ping @jasnell |
Ref: #13527
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
test