Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update new CTC members #13534

Closed
wants to merge 1 commit into from
Closed

Update new CTC members #13534

wants to merge 1 commit into from

Conversation

refack
Copy link
Contributor

@refack refack commented Jun 7, 2017

Ref: #12789
Ref: #12790

Checklist
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 7, 2017
@joyeecheung
Copy link
Member

Note that #13284 is coming...(or the other way around)

@refack
Copy link
Contributor Author

refack commented Jun 8, 2017

Note that #13284 is coming...(or the other way around)

I know, it's my small way to congratulate you both 🎉 🎆 🍾

Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't think this needs to wait 48 hours.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XadillaX
Copy link
Contributor

XadillaX commented Jun 8, 2017

Congratulations!

@refack
Copy link
Contributor Author

refack commented Jun 8, 2017

@mcollina @joyeecheung , one of you want to do the honors?

@mcollina
Copy link
Member

mcollina commented Jun 8, 2017

Landed as d958bf8 🎉 !

@mcollina mcollina closed this Jun 8, 2017
mcollina pushed a commit that referenced this pull request Jun 8, 2017
Ref: #12789
Ref: #12790
PR-URL: #13534
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@refack refack deleted the ctc-patch-1 branch June 8, 2017 17:01
addaleax pushed a commit that referenced this pull request Jun 10, 2017
Ref: #12789
Ref: #12790
PR-URL: #13534
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@addaleax addaleax mentioned this pull request Jun 10, 2017
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
3 tasks
MylesBorins pushed a commit that referenced this pull request Jul 17, 2017
Ref: #12789
Ref: #12790
PR-URL: #13534
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants