test: fix flaky test-tls-socket-close #13529
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add error listener to ignore `ECONNRESET`. Makes test reliable while it still segfaults (as expected) on Node.js 7.7.3. It might not be possible to eliminate the probable race causing `ECONNRESET` without also eliminating the required segfault-inducing part of the test. (Or maybe it's totally possible. If you figure it out, hey cool, submit a pull request.) Fixes: nodejs#13184
Trott
added
test
|
CI: https://ci.nodejs.org/job/node-test-pull-request/8540/ Stress test on master/osx1010 (should fail, demonstrating the test is currently flaky): https://ci.nodejs.org/job/node-stress-single-test/1279/ Same stress test on this PR/osx1010 (should succeed, showing this change fixes the flakiness): If anyone verifies the segfault on Node.js 7.7.3, note that both the original test and this version of it only segfault around 40% of the time (or at least that's what I'm getting). (I guess a PR that improves that to 100% or closer to 100% would be welcome, as long as it doesn't re-introduce flakiness.) |
refack
approved these changes
Jun 7, 2017
cjihrig
approved these changes
Jun 8, 2017
jasnell
approved these changes
Jun 9, 2017
|
Sole CI failure is unrelated. Stress tests also look good. |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jun 10, 2017
Add error listener to ignore `ECONNRESET`. Makes test reliable while it still segfaults (as expected) on Node.js 7.7.3. It might not be possible to eliminate the probable race causing `ECONNRESET` without also eliminating the required segfault-inducing part of the test. (Or maybe it's totally possible. If you figure it out, hey cool, submit a pull request.) PR-URL: nodejs#13529 Fixes: nodejs#13184 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in dde4f0f |
addaleax
pushed a commit
that referenced
this pull request
Jun 10, 2017
Add error listener to ignore `ECONNRESET`. Makes test reliable while it still segfaults (as expected) on Node.js 7.7.3. It might not be possible to eliminate the probable race causing `ECONNRESET` without also eliminating the required segfault-inducing part of the test. (Or maybe it's totally possible. If you figure it out, hey cool, submit a pull request.) PR-URL: #13529 Fixes: #13184 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
3 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Jul 17, 2017
Add error listener to ignore `ECONNRESET`. Makes test reliable while it still segfaults (as expected) on Node.js 7.7.3. It might not be possible to eliminate the probable race causing `ECONNRESET` without also eliminating the required segfault-inducing part of the test. (Or maybe it's totally possible. If you figure it out, hey cool, submit a pull request.) PR-URL: #13529 Fixes: #13184 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Trott
deleted the
reset-your-expectations-is-not-as-funny-as-i-wish-it-was
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add error listener to ignore
ECONNRESET. Makes test reliable while itstill segfaults (as expected) on Node.js 7.7.3. It might not be possible
to eliminate the probable race causing
ECONNRESETwithout alsoeliminating the required segfault-inducing part of the test. (Or maybe
it's totally possible. If you figure it out, hey cool, submit a pull
request.)
Fixes: #13184
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test tls