Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove note highlighting in GOVERNANCE doc #13420

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 2, 2017

Incorporate note into main text.

It's minor, but there is no need for a note here.

Checklist
Affected core subsystem(s)

doc

Incorporate note into main text.
@Trott Trott added the doc Issues and PRs related to the documentations. label Jun 2, 2017
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jun 2, 2017
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you ever find, like, a branch name length limit? ;)

Trott added a commit to Trott/io.js that referenced this pull request Jun 5, 2017
Incorporate note into main text.

PR-URL: nodejs#13420
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott
Copy link
Member Author

Trott commented Jun 5, 2017

Landed in f29406d

@Trott Trott closed this Jun 5, 2017
addaleax pushed a commit that referenced this pull request Jun 10, 2017
Incorporate note into main text.

PR-URL: #13420
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@addaleax addaleax mentioned this pull request Jun 10, 2017
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
3 tasks
MylesBorins pushed a commit that referenced this pull request Jul 17, 2017
Incorporate note into main text.

PR-URL: #13420
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jul 18, 2017
@Trott Trott deleted the i-do-not-like-note-callouts-sam-i-am-i-do-not-like-them-here-or-there-i-do-not-like-them-anywhere branch January 13, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants