-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: remove note highlighting in GOVERNANCE doc #13420
Closed
Trott
wants to merge
1
commit into
nodejs:master
from
Trott:i-do-not-like-note-callouts-sam-i-am-i-do-not-like-them-here-or-there-i-do-not-like-them-anywhere
Closed
doc: remove note highlighting in GOVERNANCE doc #13420
Trott
wants to merge
1
commit into
nodejs:master
from
Trott:i-do-not-like-note-callouts-sam-i-am-i-do-not-like-them-here-or-there-i-do-not-like-them-anywhere
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incorporate note into main text.
nodejs-github-bot
added
the
meta
Issues and PRs related to the general management of the project.
label
Jun 2, 2017
addaleax
approved these changes
Jun 2, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you ever find, like, a branch name length limit? ;)
gibfahn
approved these changes
Jun 3, 2017
lpinca
approved these changes
Jun 4, 2017
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jun 5, 2017
Incorporate note into main text. PR-URL: nodejs#13420 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Landed in f29406d |
addaleax
pushed a commit
that referenced
this pull request
Jun 10, 2017
Incorporate note into main text. PR-URL: #13420 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
3 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Jul 17, 2017
Incorporate note into main text. PR-URL: #13420 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Trott
deleted the
i-do-not-like-note-callouts-sam-i-am-i-do-not-like-them-here-or-there-i-do-not-like-them-anywhere
branch
January 13, 2022 22:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporate note into main text.
It's minor, but there is no need for a note here.
Checklist
Affected core subsystem(s)
doc