Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add require modules in url.md #13365

Closed
wants to merge 1 commit into from
Closed

doc: add require modules in url.md #13365

wants to merge 1 commit into from

Conversation

watilde
Copy link
Member

@watilde watilde commented Jun 1, 2017

To make the example codes in URL doc work without additional codes, it should have more lines to require modules.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module. labels Jun 1, 2017
mhdawson
mhdawson approved these changes Jun 1, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tniessen
tniessen approved these changes Jun 1, 2017
View reviewed changes
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes regarding destructuring are already covered in #13349.

@watilde
doc: add require modules in url.md
1e5dae0 
To make the example codes in URL doc work without additional codes,
it should have more lines to require modules.
@watilde
Copy link
Member Author

watilde commented Jun 3, 2017

Rebased and run lint ci: https://ci.nodejs.org/job/node-test-linter/9578/.

@watilde
Copy link
Member Author

watilde commented Jun 3, 2017

Landed in 917f86e. Thanks.

@watilde watilde closed this Jun 3, 2017
@watilde watilde deleted the feature/docs-url branch June 3, 2017 11:25
watilde added a commit that referenced this pull request Jun 3, 2017
@watilde
doc: add require modules in url.md
917f86e 
To make the example codes in URL doc work without additional codes,
it should have more lines to require modules.

PR-URL: #13365
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
jasnell pushed a commit that referenced this pull request Jun 5, 2017
@watilde @jasnell
doc: add require modules in url.md
11e428d 
To make the example codes in URL doc work without additional codes,
it should have more lines to require modules.

PR-URL: #13365
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@jasnell jasnell mentioned this pull request Jun 5, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@mhdawson mhdawson mhdawson approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@gibfahn gibfahn gibfahn approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@watilde @jasnell @cjihrig @tniessen @mhdawson @vsemozhetbyt @gibfahn @MylesBorins @nodejs-github-bot