doc: remove 'you' from writing-tests.md #13319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsemozhetbyt
approved these changes
May 30, 2017
|
The commit and PR titles are a bit scary :) Maybe |
cjihrig
approved these changes
May 30, 2017
jasnell
approved these changes
May 30, 2017
|
It's quite amusing that http://www2.ivcc.edu/rambo/tip_formal_writing_voice.htm uses "you" the whole way through. |
Trott
reviewed
May 30, 2017
doc/guides/writing-tests.md
Outdated
| @@ -232,8 +232,8 @@ For performance considerations, we only use a selected subset of ES.Next | |||
| features in JavaScript code in the `lib` directory. However, when writing | |||
| tests, for the ease of backporting, it is encouraged to use those ES.Next | |||
| features that can be used directly without a flag in [all maintained branches] | |||
| (https://github.com/nodejs/lts), you can check [node.green](http://node.green) | |||
| for all available features in each release. | |||
| (https://github.com/nodejs/lts), [node.green](http://node.green) can be used | |||
There was a problem hiding this comment.
While we're in here, fix the comma splice? (The comma here should be a period and node.green is the start of a new sentence.)
For that matter, maybe eliminate the passive voice in that new sentence and add a normative trailing / to the URL?
node.green lists available features in each release.
Trott
reviewed
May 30, 2017
doc/guides/writing-tests.md
Outdated
| @@ -274,8 +274,8 @@ These imported tests will be wrapped like this: | |||
| /* eslint-enable */ | |||
| ``` | |||
|
|
|||
| If you want to improve tests that have been imported this way, please send | |||
| a PR to the upstream project first. When your proposed change is merged in | |||
| In order to improve tests that have been imported this way, please send | |||
There was a problem hiding this comment.
Nit: Remove In order:
To improve tests that have been imported this way, please send...
lpinca
approved these changes
May 31, 2017
mhdawson
changed the title
Noticed this while reading through writing-tests.md today. As per style guide avoid the use of you, your etc. Rational as per: http://www2.ivcc.edu/rambo/tip_formal_writing_voice.htm
|
Pushed commits to address comments. |
|
CI good, landed as 449dd71 |
mhdawson
added a commit
that referenced
this pull request
Jun 1, 2017
Noticed this while reading through writing-tests.md today. As per style guide avoid the use of you, your etc. Rational as per: http://www2.ivcc.edu/rambo/tip_formal_writing_voice.htm PR-URL: #13319 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Jun 5, 2017
Noticed this while reading through writing-tests.md today. As per style guide avoid the use of you, your etc. Rational as per: http://www2.ivcc.edu/rambo/tip_formal_writing_voice.htm PR-URL: #13319 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Closed
3 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Jul 17, 2017
Noticed this while reading through writing-tests.md today. As per style guide avoid the use of you, your etc. Rational as per: http://www2.ivcc.edu/rambo/tip_formal_writing_voice.htm PR-URL: #13319 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this while reading through writing-tests.md today.
As per style guide avoid the use of you, your etc.
Rational as per: http://www2.ivcc.edu/rambo/tip_formal_writing_voice.htm
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc