test: test requests with Unicode in the URL #13297
Conversation
This test currently fails. It illustrates that Unicode in the URL does not arrive intact to the server, there is silent data corruption along the way at some point. This test is for the issue nodejs#13296.
| // NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, | ||
| // DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR | ||
| // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE | ||
| // USE OR OTHER DEALINGS IN THE SOFTWARE. |
There was a problem hiding this comment.
New files do not need the copyright header at the top
| 'Sanity check that string literal produced the expected string' | ||
| ); | ||
|
|
||
| const server = http.Server(function(req, res) { |
| const server = http.Server(function(req, res) { | ||
| result = req.url; | ||
| req.on('data', function() { | ||
| }).on('end', function() { |
There was a problem hiding this comment.
these should be wrapped in common.mustCall()
| path: expected, | ||
| method: 'GET' | ||
| }, function(res) { | ||
| console.log(res.statusCode); |
There was a problem hiding this comment.
Please omit the extraneous console output
| }).end(); | ||
| }); | ||
|
|
||
| process.on('exit', function() { |
There was a problem hiding this comment.
If using common.mustCall() and inline asserts, there's no need for an exit handler.
|
I've moved the test to |
|
Thank you @Flimm ... moving the test to known_issues is particularly useful as those are actually run in CI with the expectation that they will fail. That way, if they end up getting fixed somehow, we'll know right away. As for the style of the other tests, we've been slowly and incrementally updating all of the existing tests. |
This test currently fails. It illustrates that Unicode in the URL does not arrive intact to the server, there is silent data corruption along the way at some point. This test is for the issue #13296. PR-URL: #13297 Reviewed-By: James M Snell <[email protected]>
|
Landed in 592d7d2 |
This test currently fails. It illustrates that Unicode in the URL does not arrive intact to the server, there is silent data corruption along the way at some point. This test is for the issue #13296. PR-URL: #13297 Reviewed-By: James M Snell <[email protected]>
This test currently fails. It illustrates that Unicode in the URL does not arrive intact to the server, there is silent data corruption along the way at some point. This test is for the issue #13296. PR-URL: #13297 Reviewed-By: James M Snell <[email protected]>
This test currently fails. It illustrates that Unicode in the URL does
not arrive intact to the server, there is silent data corruption along
the way at some point.
This test is for the issue #13296.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes (this doesn't pass, as the test is only an illustration for a bug)Affected core subsystem(s)
http