Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: drop homegrown thread pool, use libplatform #1329

Merged
merged 1 commit into from
Apr 3, 2015
Merged

src: drop homegrown thread pool, use libplatform #1329

merged 1 commit into from
Apr 3, 2015

Commits on Apr 3, 2015

  1. src: drop homegrown thread pool, use libplatform 

    Drop the homegrown thread pool that was introduced in commit 50839a0
("v8_platform: provide default v8::Platform impl") and use one from
V8's libplatform library.  Performance is comparable and it removes
a few hundred lines of code.

The calls to v8::platform::PumpMessageLoop() are currently no-ops
because V8 does not (yet?) use v8::Platform::CallOnForegroundThread().

Packagers that link against a shared libv8 now also need to make
libv8_platform available.

PR-URL: nodejs#1329
Reviewed-By: Fedor Indutny <[email protected]>
    @bnoordhuis
    bnoordhuis committed Apr 3, 2015
    Configuration menu
    Copy the full SHA
    4a801c2 View commit details
    Browse the repository at this point in the history