doc: fix api docs style #13236
Closed
doc: fix api docs style #13236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doc/api/fs.md + L314: Missing code-language flag doc/api/stream.md + L2120: Do not use definitions with the same identifier + L2121: Do not use definitions with the same identifier + L2122: Do not use definitions with the same identifier doc/api/v8.md + L157: Move definitions to the end of the file + L158: Move definitions to the end of the file + L159: Move definitions to the end of the file + L160: Move definitions to the end of the file
watilde
commented
May 26, 2017
| @@ -2145,6 +2145,3 @@ readable buffer so there is nothing for a user to consume. | |||
| [stream-write]: #stream_writable_write_chunk_encoding_callback | |||
| [readable-_destroy]: #stream_readable_destroy_err_callback | |||
| [writable-_destroy]: #stream_writable_destroy_err_callback | |||
| [TCP sockets]: net.html#net_class_net_socket | |||
There was a problem hiding this comment.
they were duplicated on doc/api/stream.md#L2125-L2127.
lpinca
approved these changes
May 26, 2017
refack
approved these changes
May 26, 2017
aqrln
approved these changes
May 26, 2017
|
Landed in a94b98e. Thanks! |
watilde
added a commit
that referenced
this pull request
May 28, 2017
doc/api/fs.md + L314: Missing code-language flag doc/api/stream.md + L2120: Do not use definitions with the same identifier + L2121: Do not use definitions with the same identifier + L2122: Do not use definitions with the same identifier doc/api/v8.md + L157: Move definitions to the end of the file + L158: Move definitions to the end of the file + L159: Move definitions to the end of the file + L160: Move definitions to the end of the file PR-URL: #13236 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
May 29, 2017
doc/api/fs.md + L314: Missing code-language flag doc/api/stream.md + L2120: Do not use definitions with the same identifier + L2121: Do not use definitions with the same identifier + L2122: Do not use definitions with the same identifier doc/api/v8.md + L157: Move definitions to the end of the file + L158: Move definitions to the end of the file + L159: Move definitions to the end of the file + L160: Move definitions to the end of the file PR-URL: #13236 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
3 tasks
|
This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same with this: #13066. To avoid more conflicts at #12756, it's better to fix
mdlinterrors in upstream.Summary
doc/api/fs.md
doc/api/stream.md
doc/api/v8.md
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc