src: clean up SafeGetenv() #13220
src: clean up SafeGetenv() #13220
Conversation
nodejs-github-bot
added
the
c++
src/node.cc
Outdated
| return false; | ||
| } | ||
|
|
||
| #if defined(__linux__) |
There was a problem hiding this comment.
I might have misunderstood the code review but it was intentional to not have the macro guard (__linux__) here. Perhaps the variable should also be guarded in node_main.cc and node.cc?
There was a problem hiding this comment.
Hm, we could skip the #ifdef __linux__ ugliness mentioned there, and just add linux_at_secure into the existing if (getuid() != geteuid() || getgid() != getegid()) check. Whichever you prefer.
There was a problem hiding this comment.
I'd opt for not having the #ifdef if that is acceptable.
There was a problem hiding this comment.
Yes, the idea was to have as little code behind ifdefs as possible.
|
Removed extra |
PR-URL: nodejs#13220 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #13220 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
|
Should this land on v6.x? |
|
ping @cjihrig |
|
It can. It's not critical though. |
|
this is not landing cleanly. Putting "don't land" for now. |
This commit:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src