Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: remove dup property #13216

Merged
merged 1 commit into from
May 25, 2017

Conversation

calvinmetcalf
Copy link
Contributor

looks like #12828 accidentally got a double property definition, as mentioned here, this removes that

@nodejs-github-bot nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label May 25, 2017
@calvinmetcalf
Copy link
Contributor Author

considering how trivial this is I'll plan on landing this in the next hour or 2 unless anyone objects

Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I’m good with landing this now

@calvinmetcalf
Copy link
Contributor Author

@addaleax whats your email so I can include you in the reviewed lines ?

@addaleax
Copy link
Member

@calvinmetcalf [email protected] … if you’re unsure about those, you can always just copy the lines from our README :)

@lpinca
Copy link
Member

lpinca commented May 25, 2017

@calvinmetcalf I usually copy/paste the latest available in git log after searching reviewer by name.

PR-URL: nodejs#13216
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@calvinmetcalf
Copy link
Contributor Author

@lpinca I had been doing that but couldn't find it in any recent ones and totally forgot about her email in the readme

@calvinmetcalf
Copy link
Contributor Author

155687c

@calvinmetcalf calvinmetcalf merged commit 155687c into nodejs:master May 25, 2017
jasnell pushed a commit that referenced this pull request May 25, 2017
PR-URL: #13216
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
jasnell pushed a commit that referenced this pull request May 28, 2017
PR-URL: #13216
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@jasnell jasnell mentioned this pull request May 28, 2017
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
3 tasks
@MylesBorins
Copy link
Contributor

This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stream Issues and PRs related to the stream subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants