Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(v6.x backport) zlib: fix node crashing on invalid options #13201

Closed
wants to merge 2 commits into from
Closed

(v6.x backport) zlib: fix node crashing on invalid options #13201

wants to merge 2 commits into from

Commits on May 24, 2017

  1. zlib: fix node crashing on invalid options 

    This is a partial backport of semver-patch bits of
9e4660b.

This commit fixes the Node process crashing when constructors of classes
of the zlib module are given invalid options.

* Throw an Error when the zlib library rejects the value of windowBits,
  instead of crashing with an assertion.

* Treat windowBits and memLevel options consistently with other ones and
  don't crash when non-numeric values are given.

Refs: nodejs#13098
    @aqrln
    aqrln committed May 24, 2017
    Configuration menu
    Copy the full SHA
    9619966 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2017

  1. squash! address the nits

    @aqrln
    aqrln committed May 25, 2017
    Configuration menu
    Copy the full SHA
    9fa7d7d View commit details
    Browse the repository at this point in the history