Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: remove root_cert_store from node_crypto.h #13194

Closed
wants to merge 2 commits into from
Closed

crypto: remove root_cert_store from node_crypto.h #13194

wants to merge 2 commits into from

Commits on May 24, 2017

  1. crypto: remove root_cert_store from node_crypto.h 

    root_cert_store is defined as extern in node_crypto.h but only used in
node_crypto.cc. It is then set using SSL_CTX_set_cert_store. The only
usages of SSL_CTX_get_cert_store are in node_crypto.cc which would all
be accessing the same X509_STORE through the root_cert_store pointer as
far as I can tell. Am I missing something here?

This commit suggests removing it from the header and making it static
in node_crypto.cc.
    @danbev
    danbev committed May 24, 2017
    Configuration menu
    Copy the full SHA
    dae7163 View commit details
    Browse the repository at this point in the history

  2. make extra_root_certs_file and root_certs static

    @danbev
    danbev committed May 24, 2017
    Configuration menu
    Copy the full SHA
    3a5646c View commit details
    Browse the repository at this point in the history